lkml.org 
[lkml]   [2024]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 05/11] PCI: cadence: Extract link setup sequence from cdns_pcie_host_setup()
    On Tue, Apr 16, 2024 at 03:29:54PM +0200, Thomas Richard wrote:
    > diff --git a/drivers/pci/controller/cadence/pcie-cadence-host.c b/drivers/pci/controller/cadence/pcie-cadence-host.c
    > index 5b14f7ee3c79..93d9922730af 100644
    > --- a/drivers/pci/controller/cadence/pcie-cadence-host.c
    > +++ b/drivers/pci/controller/cadence/pcie-cadence-host.c
    > @@ -497,6 +497,30 @@ static int cdns_pcie_host_init(struct device *dev,
    > return cdns_pcie_host_init_address_translation(rc);
    > }
    >
    > +int cdns_pcie_host_link_setup(struct cdns_pcie_rc *rc)
    > +{
    > + struct cdns_pcie *pcie = &rc->pcie;
    > + struct device *dev = rc->pcie.dev;
    > + int ret;
    > +
    > + if (rc->quirk_detect_quiet_flag)
    > + cdns_pcie_detect_quiet_min_delay_set(&rc->pcie);
    > +
    > + cdns_pcie_host_enable_ptm_response(pcie);
    > +
    > + ret = cdns_pcie_start_link(pcie);
    > + if (ret) {
    > + dev_err(dev, "Failed to start link\n");
    > + return ret;
    > + }
    > +
    > + ret = cdns_pcie_host_start_link(rc);
    > + if (ret)
    > + dev_dbg(dev, "PCIe link never came up\n");

    If we're going to ignore this error the message should be a dev_err()
    at least.


    > +
    > + return 0;
    > +}
    > +

    regards,
    dan carpenter

    \
     
     \ /
      Last update: 2024-05-27 16:40    [W:3.165 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site