Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Arınç ÜNAL via B4 Relay <> | Date | Sun, 14 Apr 2024 00:08:13 +0300 | Subject | [PATCH net-next] net: phy: mediatek-ge: do not disable EEE advertisement |
| |
From: Arınç ÜNAL <arinc.unal@arinc9.com>
The mediatek-ge PHY driver already disables EEE advertisement on the switch PHYs but my testing [1] shows that it is somehow enabled afterwards. Disabling EEE advertisement before the PHY driver initialises keeps it off. Therefore, remove disabling EEE advertisement here as it's useless.
Link: https://lore.kernel.org/netdev/d286ea27-e911-4dcb-9037-b75f22b437b8@arinc9.com/ [1] Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- drivers/net/phy/mediatek-ge.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c index a493ae01b267..54ea64a37ab3 100644 --- a/drivers/net/phy/mediatek-ge.c +++ b/drivers/net/phy/mediatek-ge.c @@ -23,9 +23,6 @@ static int mtk_gephy_write_page(struct phy_device *phydev, int page) static void mtk_gephy_config_init(struct phy_device *phydev) { - /* Disable EEE */ - phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_EEE_ADV, 0); - /* Enable HW auto downshift */ phy_modify_paged(phydev, MTK_PHY_PAGE_EXTENDED, 0x14, 0, BIT(4)); --- base-commit: 32affa5578f0e6b9abef3623d3976395afbd265c change-id: 20240321-for-netnext-mediatek-ge-do-not-disable-eee-adv-b67dfccf9811 Best regards, -- Arınç ÜNAL <arinc.unal@arinc9.com>
| ![\](/images/icornerr.gif) |