Messages in this thread | | | Date | Sun, 14 Apr 2024 10:35:43 +0300 | From | Mike Rapoport <> | Subject | Re: [RFC PATCH 5/7] x86/module: perpare module loading for ROX allocations of text |
| |
On Fri, Apr 12, 2024 at 11:08:00AM +0200, Ingo Molnar wrote: > > * Mike Rapoport <rppt@kernel.org> wrote: > > > for (s = start; s < end; s++) { > > void *addr = (void *)s + *s; > > + void *wr_addr = addr + module_writable_offset(mod, addr); > > So instead of repeating this pattern in a dozen of places, why not use a > simpler method: > > void *wr_addr = module_writable_address(mod, addr); > > or so, since we have to pass 'addr' to the module code anyway.
Agree.
> The text patching code is pretty complex already. > > Thanks, > > Ingo
-- Sincerely yours, Mike.
| |