Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 11 Apr 2024 17:54:45 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 1/2] serial: exar: add missing CTI/Exar PCI IDs to include/linux/pci_ids.h |
| |
On Thu, Apr 11, 2024 at 11:29:26AM -0400, parker@finest.io wrote: > From: Parker Newman <pnewman@connecttech.com> > > - Added missing CTI serial car PCI IDs > - Added missing Exar XR17V25X PCI IDs > - Moved XR17V4358 and XR17V8358 PCI ID defines to pci_ids.h
Did you read the top of the pci_ids.h file? Don't add new ids there unless it is going to be needed in multiple files please.
thanks,
greg k-h
| ![\](/images/icornerr.gif) |