Messages in this thread | | | Date | Wed, 10 Apr 2024 15:43:45 +0100 | Subject | Re: [PATCH v2] ASoC: soc-card: soc-card-test: Fix some error handling in probe() | From | Richard Fitzgerald <> |
| |
On 10/4/24 15:22, Dan Carpenter wrote: > Fix this reversed if statement and call put_device() before returning > the error code. > > Fixes: ef7784e41db7 ("ASoC: soc-card: Add KUnit test case for snd_soc_card_get_kcontrol") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > v2: call put_device() > > sound/soc/soc-card-test.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/soc-card-test.c b/sound/soc/soc-card-test.c > index 075c52fe82e5..faf9a3d46884 100644 > --- a/sound/soc/soc-card-test.c > +++ b/sound/soc/soc-card-test.c > @@ -148,8 +148,10 @@ static int soc_card_test_case_init(struct kunit *test) > priv->card->owner = THIS_MODULE; > > ret = snd_soc_register_card(priv->card); > - if (!ret) > + if (ret) { > + put_device(priv->card_dev); > return ret; > + } > > return 0; > }
Thanks. Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
I can see that put_device() is also missing earlier in the function:
if (!priv->card) return -ENOMEM;
I can send a fix for that.
| |