Messages in this thread | | | Date | Wed, 10 Apr 2024 08:45:05 +0200 | Subject | Re: [PATCH v5 6/6] nvmet: return DHCHAP status codes from nvmet_setup_auth() | From | Hannes Reinecke <> |
| |
On 4/9/24 22:23, Sagi Grimberg wrote: > > > On 09/04/2024 12:35, Daniel Wagner wrote: >> From: Hannes Reinecke <hare@kernel.org> >> >> A failure in nvmet_setup_auth() does not mean that the NVMe >> authentication command failed, so we should rather return a protocol >> error with a 'failure1' response than an NVMe status. >> >> Also update the type used for dhchap_step and dhchap_status to u8 to >> avoid confusions with nvme status. Furthermore, split dhchap_status and >> nvme status so we don't accidentally mix these return values. > > What is the implications of this on the host behavior? In other > words, why is this a part of the series?
This issue came up during testing the series, where we found that the target would cause connection failure (ie return the NVMe CQE with a status code) rather than a protocol error (ie return the NVMe CQE with a 'good' status, and set the 'failure1' status for DH-CHAP). And with that a termination of the DH-CHAP protocol, and not a connection reset. So not directly related, but required to get the testcase for this series working.
Cheers,
Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
| |