lkml.org 
[lkml]   [2024]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 04/24] drivers/perf: riscv: Use BIT macro for shifting operations
    Date
    It is a good practice to use BIT() instead of (1 << x).
    Replace the current usages with BIT().

    Take this opportunity to replace few (1UL << x) with BIT() as well
    for consistency.

    Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
    Signed-off-by: Atish Patra <atishp@rivosinc.com>
    ---
    arch/riscv/include/asm/sbi.h | 20 ++++++++++----------
    drivers/perf/riscv_pmu_sbi.c | 2 +-
    2 files changed, 11 insertions(+), 11 deletions(-)

    diff --git a/arch/riscv/include/asm/sbi.h b/arch/riscv/include/asm/sbi.h
    index ef8311dafb91..4afa2cd01bae 100644
    --- a/arch/riscv/include/asm/sbi.h
    +++ b/arch/riscv/include/asm/sbi.h
    @@ -233,20 +233,20 @@ enum sbi_pmu_ctr_type {
    #define SBI_PMU_EVENT_IDX_INVALID 0xFFFFFFFF

    /* Flags defined for config matching function */
    -#define SBI_PMU_CFG_FLAG_SKIP_MATCH (1 << 0)
    -#define SBI_PMU_CFG_FLAG_CLEAR_VALUE (1 << 1)
    -#define SBI_PMU_CFG_FLAG_AUTO_START (1 << 2)
    -#define SBI_PMU_CFG_FLAG_SET_VUINH (1 << 3)
    -#define SBI_PMU_CFG_FLAG_SET_VSINH (1 << 4)
    -#define SBI_PMU_CFG_FLAG_SET_UINH (1 << 5)
    -#define SBI_PMU_CFG_FLAG_SET_SINH (1 << 6)
    -#define SBI_PMU_CFG_FLAG_SET_MINH (1 << 7)
    +#define SBI_PMU_CFG_FLAG_SKIP_MATCH BIT(0)
    +#define SBI_PMU_CFG_FLAG_CLEAR_VALUE BIT(1)
    +#define SBI_PMU_CFG_FLAG_AUTO_START BIT(2)
    +#define SBI_PMU_CFG_FLAG_SET_VUINH BIT(3)
    +#define SBI_PMU_CFG_FLAG_SET_VSINH BIT(4)
    +#define SBI_PMU_CFG_FLAG_SET_UINH BIT(5)
    +#define SBI_PMU_CFG_FLAG_SET_SINH BIT(6)
    +#define SBI_PMU_CFG_FLAG_SET_MINH BIT(7)

    /* Flags defined for counter start function */
    -#define SBI_PMU_START_FLAG_SET_INIT_VALUE (1 << 0)
    +#define SBI_PMU_START_FLAG_SET_INIT_VALUE BIT(0)

    /* Flags defined for counter stop function */
    -#define SBI_PMU_STOP_FLAG_RESET (1 << 0)
    +#define SBI_PMU_STOP_FLAG_RESET BIT(0)

    enum sbi_ext_dbcn_fid {
    SBI_EXT_DBCN_CONSOLE_WRITE = 0,
    diff --git a/drivers/perf/riscv_pmu_sbi.c b/drivers/perf/riscv_pmu_sbi.c
    index 1823ffb25d35..f23501898657 100644
    --- a/drivers/perf/riscv_pmu_sbi.c
    +++ b/drivers/perf/riscv_pmu_sbi.c
    @@ -386,7 +386,7 @@ static int pmu_sbi_ctr_get_idx(struct perf_event *event)
    cmask = 1;
    } else if (event->attr.config == PERF_COUNT_HW_INSTRUCTIONS) {
    cflags |= SBI_PMU_CFG_FLAG_SKIP_MATCH;
    - cmask = 1UL << (CSR_INSTRET - CSR_CYCLE);
    + cmask = BIT(CSR_INSTRET - CSR_CYCLE);
    }
    }

    --
    2.34.1

    \
     
     \ /
      Last update: 2024-05-27 16:33    [W:4.125 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site