Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 10 Apr 2024 13:40:09 +0800 | Subject | Re: [PATCH 2/2] iommu/vt-d: Remove caching mode check before devtlb flush | From | Baolu Lu <> |
| |
On 4/9/24 3:30 PM, Tian, Kevin wrote: >> Remove the caching mode check before device TLB invalidation to ensure >> compatibility with the scalable mode use cases. >> >> Fixes: 792fb43ce2c9 ("iommu/vt-d: Enable Intel IOMMU scalable mode by >> default") >> Signed-off-by: Lu Baolu<baolu.lu@linux.intel.com> >> --- >> drivers/iommu/intel/iommu.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c >> index 493b6a600394..681789b1258d 100644 >> --- a/drivers/iommu/intel/iommu.c >> +++ b/drivers/iommu/intel/iommu.c >> @@ -1501,7 +1501,7 @@ static void iommu_flush_iotlb_psi(struct >> intel_iommu *iommu, >> else >> __iommu_flush_iotlb_psi(iommu, did, pfn, pages, ih); >> >> - if (!cap_caching_mode(iommu->cap) && !map) >> + if (!map) >> iommu_flush_dev_iotlb(domain, addr, mask); > as commented earlier better squash this in patch1.
Okay, let me squash them into a single patch and make the commit message more descriptive.
Best regards, baolu
| ![\](/images/icornerr.gif) |