Messages in this thread | | | Date | Wed, 10 Apr 2024 15:33:05 -0700 | Subject | Re: [PATCH net] octeontx2-pf: fix FLOW_DIS_IS_FRAGMENT implementation | From | Jacob Keller <> |
| |
On 4/10/2024 6:43 AM, Asbjørn Sloth Tønnesen wrote: > Upon reviewing the flower control flags handling in > this driver, I notice that the key wasn't being used, > only the mask. > > Ie. `tc flower ... ip_flags nofrag` was hardware > offloaded as `... ip_flags frag`. > > Only compile tested, no access to HW. > > Fixes: c672e3727989 ("octeontx2-pf: Add support to filter packet based on IP fragment") > Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net> > --- >
I know nothing about this hardware, but the change does match your description. Hopefully someone from Marvell can comment on the hardware aspect.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> This is a best guess on a fix, I don't know if it will work, > but hopefully someone at Marvell can test it. > > The more certain alternative would be to set an error msg. > and return -EOPNOTSUPP, when `tc flower ip_flags nofrag` > is used.
| |