Messages in this thread | | | Date | Wed, 10 Apr 2024 18:32:14 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 3/6] perf annotate-data: Add hist_entry__annotate_data_tui() |
| |
On Wed, Apr 10, 2024 at 06:20:06PM -0300, Arnaldo Carvalho de Melo wrote: > On Wed, Apr 10, 2024 at 06:17:16PM -0300, Arnaldo Carvalho de Melo wrote: > > On Wed, Apr 10, 2024 at 06:12:32PM -0300, Arnaldo Carvalho de Melo wrote: > > > On Wed, Apr 10, 2024 at 06:05:27PM -0300, Arnaldo Carvalho de Melo wrote: > > > > On Wed, Apr 10, 2024 at 06:04:26PM -0300, Arnaldo Carvalho de Melo wrote: > > > > > On Wed, Apr 10, 2024 at 05:21:01PM -0300, Arnaldo Carvalho de Melo wrote: > > > > > > On Tue, Apr 09, 2024 at 04:49:57PM -0700, Namhyung Kim wrote: > > > > > > > Support data type profiling output on TUI. > > > > > > > > > > > > Added the follow to the commit log message, to make reviewing easier. > > > > > > > > > > > > As followup patches I think having the DSO name together with the type > > > > > > is important, also I think we could have a first menu with all the pairs > > > > > > of DSO/type, sorted top down by the types with most samples, wdyt? > > > > > > > > > > > > Applied. > > > > > > > > > > > > > > > > There is something else here with the static build, checking... > > > > > > > > Probably because of: > > > > > > > > Makefile.config:810: slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev > > > > > > > > Fixing... > > > > > > Trying with: > > > > Not really, I need to check for HAVE_DWARF_SUPPORT as well? Doing that > > Attempting with:
Nope, the surgery needed is a bit bigger, as you made hist_entry__annotate_data_tty dependent on DWARF but calls it without checking HAVE_DWARF_SUPPORT from builtin-annotate.c.
I put what I have in tmp.perf-tools-next, please take a look, I'll continue tomorrow.
- Arnaldo
> ⬢[acme@toolbox perf-tools-next]$ git diff > diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c > index 458eafe65e4aa16f..521ec7e226e29e6b 100644 > --- a/tools/perf/builtin-annotate.c > +++ b/tools/perf/builtin-annotate.c > @@ -469,7 +469,7 @@ static void hists__find_annotations(struct hists *hists, > goto find_next; > } > > -#ifdef HAVE_SLANG_SUPPORT > +#if defined(HAVE_SLANG_SUPPORT) && defined(HAVE_DWARF_SUPPORT) > if (use_browser == 1) > key = hist_entry__annotate_data_tui(he, evsel, NULL); > else > ⬢[acme@toolbox perf-tools-next]$
| |