Messages in this thread | ![/](/images/icornerl.gif) | | From | 许春光 <> | Date | Sat, 9 Mar 2024 00:43:12 +0800 | Subject | Re: [PATCH v3] nvme: fix reconnection fail due to reserved tag allocation |
| |
Christoph Hellwig <hch@lst.de> 于2024年3月9日周六 00:31写道: > > On Sat, Mar 09, 2024 at 12:29:27AM +0800, 许春光 wrote: > > This works now, but I donot know whether > > nvme_alloc_admin_tag_set()/nvme_alloc_io_tag_set() > > will be suitable for all driver in future, such as driver for apple > > device not use these two funcs > > to init tagset (anyway it not use these two macros too), so maybe new > > driver would use these > > value in other position. > > nvme-apply should realy be converted to use the generic helpers, > I just need some help from the maintainers. I'll ping them. noted, that sounds great.
> > But I'm fine with just taking this bug fix as-is and clean this up > later.
Sorry for delay to reply, I found the patch have applied just about 10 minutes ago. According what you plan to do, I think as-is maybe fine, But anyway if need, I will send another patch to cleanup, thanks.
| ![\](/images/icornerr.gif) |