Messages in this thread | | | Date | Sat, 9 Mar 2024 12:45:30 -0800 | From | Kees Cook <> | Subject | Re: [PATCH] liquidio: Fix potential null pointer dereference |
| |
On Fri, Mar 08, 2024 at 08:19:11PM +0000, Simon Horman wrote: > On Thu, Mar 07, 2024 at 12:29:32PM +0300, Aleksandr Mishin wrote: > > In lio_vf_rep_copy_packet() pg_info->page is compared to a NULL value, > > but then it is unconditionally passed to skb_add_rx_frag() which could > > lead to null pointer dereference. > > Fix this bug by moving skb_add_rx_frag() into conditional scope. > > > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > > > Fixes: 1f233f327913 (liquidio: switchdev support for LiquidIO NIC) > > A correct format for the tag above is: > > Fixes: 1f233f327913 ("liquidio: switchdev support for LiquidIO NIC")
FWIW, I have this in my ~/.gitconfig[1]:
[alias] short = "!f() { for i in \"$@\"; do git log -1 --pretty='%h (\"%s\")' \"$i\"; done; }; f"
then I can type:
$ short 1f233f327913f3dee0602cba9c64df1903772b55 1f233f327913 ("liquidio: switchdev support for LiquidIO NIC")
-Kees
[1] https://github.com/kees/kernel-tools/blob/trunk/ENVIRONMENT.md#git-command-aliases-gitconfig
-- Kees Cook
| |