Messages in this thread | | | Date | Fri, 08 Mar 2024 10:16:42 +0100 | From | Théo Lebrun <> | Subject | Re: [PATCH v3 08/11] i2c: nomadik: support Mobileye EyeQ5 I2C controller |
| |
Hello Andi,
On Fri Mar 8, 2024 at 12:11 AM CET, Andi Shyti wrote: > Hi Theo, > > ... > > > +static inline u8 nmk_i2c_readb(const struct nmk_i2c_dev *priv, > > + unsigned long reg) > > +{ > > + if (priv->has_32b_bus) > > + return readl(priv->virtbase + reg); > > + else > > + return readb(priv->virtbase + reg); > > +} > > you forgot to remove the else... not a problem, it's coherent > with its writeb counterpart.
Yes I enjoy symmetry. :-)
[...]
> Looks good! > > Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Thanks Andi! Any chance of seeing this series queued for v6.9?
Regards,
-- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |