Messages in this thread |  | | From | Vincent Guittot <> | | Date | Fri, 8 Mar 2024 13:03:12 +0100 | | Subject | Re: [PATCH 07/10] sched/balancing: Fix comments (trying to) refer to NOHZ_BALANCE_KICK |
| |
On Fri, 8 Mar 2024 at 11:59, Ingo Molnar <mingo@kernel.org> wrote: > > Fix two typos: > > - There's no such thing as 'nohz_balancing_kick', the > flag is named 'BALANCE' and is capitalized: NOHZ_BALANCE_KICK. > > - Likewise there's no such thing as a 'pending nohz_balance_kick' > either, the NOHZ_BALANCE_KICK flag is all upper-case. > > Signed-off-by: Ingo Molnar <mingo@kernel.org> > Reviewed-by: Valentin Schneider <vschneid@redhat.com> > Cc: Dietmar Eggemann <dietmar.eggemann@arm.com> > Cc: Linus Torvalds <torvalds@linux-foundation.org> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Shrikanth Hegde <sshegde@linux.ibm.com> > Cc: Vincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
> --- > kernel/sched/fair.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 84d4791cf628..f3c03c6db3c8 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -12409,15 +12409,16 @@ static int newidle_balance(struct rq *this_rq, struct rq_flags *rf) > } > > /* > - * run_rebalance_domains is triggered when needed from the scheduler tick. > - * Also triggered for nohz idle balancing (with nohz_balancing_kick set). > + * This softirq may be triggered from the scheduler tick, or by > + * any of the flags in NOHZ_KICK_MASK: NOHZ_BALANCE_KICK, > + * NOHZ_STATS_KICK or NOHZ_NEXT_KICK. > */ > static __latent_entropy void run_rebalance_domains(struct softirq_action *h) > { > struct rq *this_rq = this_rq(); > enum cpu_idle_type idle = this_rq->idle_balance; > /* > - * If this CPU has a pending nohz_balance_kick, then do the > + * If this CPU has a pending NOHZ_BALANCE_KICK, then do the > * balancing on behalf of the other idle CPUs whose ticks are > * stopped. Do nohz_idle_balance *before* rebalance_domains to > * give the idle CPUs a chance to load balance. Else we may > -- > 2.40.1 >
|  |