Messages in this thread |  | | From | Mina Almasry <> | | Date | Fri, 8 Mar 2024 16:04:14 -0800 | | Subject | Re: [PATCH net-next v1] net: page_pool: factor out page_pool recycle check |
| |
On Fri, Mar 8, 2024 at 3:50 PM David Wei <dw@davidwei.uk> wrote: > > On 2024-03-08 12:44, Mina Almasry wrote: > > The check is duplicated in 2 places, factor it out into a common helper. > > > > Signed-off-by: Mina Almasry <almasrymina@google.com> > > Reviewed-by: Yunsheng Lin <linyunsheng@huawei.com> > > --- > > net/core/page_pool.c | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > > index d706fe5548df..dd364d738c00 100644 > > --- a/net/core/page_pool.c > > +++ b/net/core/page_pool.c > > @@ -657,6 +657,11 @@ static bool page_pool_recycle_in_cache(struct page *page, > > return true; > > } > > > > +static bool __page_pool_page_can_be_recycled(const struct page *page) > > Could this be made inline? >
Looking at the rest of the static functions in this file, they don't specify inline, just static. I guess the compiler is smart enough to inline static functions in .c files when it makes sense (and does not when it doesn't)?
But this doesn't seem to be a kernel wide thing. net/core/dev.c does have static inline functions in it, only page_pool.c doesn't do it. I guess if there are no objections I can make it static inline to ask the compiler to inline it. Likely after the merge window reopens if it closes today.
|  |