Messages in this thread | | | Date | Wed, 6 Mar 2024 22:35:37 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 1/2] virt: efi_secret: Convert to platform remove callback returning void |
| |
Hello,
On Tue, Dec 26, 2023 at 02:28:02PM +0100, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Is this patch still on someone's radar? If a resend would help, please tell me.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |