Messages in this thread | ![/](/images/icornerl.gif) | | From | Namhyung Kim <> | Date | Mon, 4 Mar 2024 10:58:56 -0800 | Subject | Re: [PATCH v2] perf vendor events intel: Add umasks/occ_sel to PCU events. |
| |
On Wed, Feb 28, 2024 at 12:46 PM Liang, Kan <kan.liang@linux.intel.com> wrote: > > > > On 2024-02-28 12:05 p.m., Ian Rogers wrote: > > UMasks were being dropped leading to all PCU > > UNC_P_POWER_STATE_OCCUPANCY events having the same encoding. Don't > > drop the umask trying to be consistent with other sources of events > > like libpfm4 [1]. Older models need to use occ_sel rather than umask, > > correct these values too. This applies the change from [2]. > > > > [1] https://sourceforge.net/p/perfmon2/libpfm4/ci/master/tree/lib/events/intel_skx_unc_pcu_events.h#l30 > > [2] https://github.com/captain5050/perfmon/commit/cbd4aee81023e5bfa09677b1ce170ff69e9c423d > > > > Signed-off-by: Ian Rogers <irogers@google.com> > > --- > > v2 corrects BDW-DE, BDX, HSX and JKT to not use umask but occ_sel. > > Thanks Ian for the fix. > > Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Applied to perf-tools-next, thanks!
Namhyung
| ![\](/images/icornerr.gif) |