lkml.org 
[lkml]   [2024]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 09/19] tools/power x86_energy_perf_policy: Fix file leak in get_pkg_num()
    Date
    From: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>

    [ Upstream commit f85450f134f0b4ca7e042dc3dc89155656a2299d ]

    In function get_pkg_num() if fopen_or_die() succeeds it returns a file
    pointer to be used. But fclose() is never called before returning from
    the function.

    Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
    index 2aba622d1c5aa..470d03e143422 100644
    --- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
    +++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
    @@ -1112,6 +1112,7 @@ unsigned int get_pkg_num(int cpu)
    retval = fscanf(fp, "%d\n", &pkg);
    if (retval != 1)
    errx(1, "%s: failed to parse", pathname);
    + fclose(fp);
    return pkg;
    }

    --
    2.43.0

    \
     
     \ /
      Last update: 2024-05-27 16:15    [W:3.003 / U:0.728 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site