Messages in this thread | | | Date | Fri, 29 Mar 2024 01:52:07 +0100 | Subject | Re: [PATCH 1/2] V2 arm64: dts: qcom: Add support for Samsung Galaxy Z Fold5 | From | Konrad Dybcio <> |
| |
On 29.03.2024 12:08 AM, Alexandru Marc Serdeliuc via B4 Relay wrote: > From: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > > Add support for Samsung Galaxy Z Fold5 (q5q) foldable phone > > Currently working features: > - Framebuffer > - UFS > - i2c > - Buttons > > Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > ---
Your commit title now includes "V2". Move it inside the square braces the next time around, so it's like [PATCH v3 1/2]. With b4, this should be done automagically, though..
[...]
> +/ { > + model = "Samsung Galaxy Z Fold5"; > + compatible = "samsung,q5q", "qcom,sm8550"; > + #address-cells = <0x02>; > + #size-cells = <0x02>;
These two can go
[...]
> + reserved-memory { > + /* > + * The bootloader will only keep display hardware enabled > + * if this memory region is named exactly 'splash_region' > + */
Ouch.
[...]
> + vreg_l15b_1p8: ldo15 { > + regulator-name = "vreg_l15b_1p8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > + regulator-allow-set-load; > + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM > + RPMH_REGULATOR_MODE_HPM>; > + regulator-always-on;
Any particular reason as to why?
[...]
> +&remoteproc_adsp { > + firmware-name = "qcom/sm8550/adsp.mbn", > + "qcom/sm8550/adsp_dtb.mbn"; > + status = "okay"; > +}; > + > +&remoteproc_cdsp { > + firmware-name = "qcom/sm8550/cdsp.mbn", > + "qcom/sm8550/cdsp_dtb.mbn"; > + status = "okay"; > +}; > + > +&remoteproc_mpss { > + firmware-name = "qcom/sm8550/modem.mbn", > + "qcom/sm8550/modem_dtb.mbn"; > + status = "okay";
Unless you stole one from the factory, these firmwares will not load on your phone..
> +}; > + > +&sleep_clk { > + clock-frequency = <32000>; > +}; > + > +&tlmm { > + gpio-reserved-ranges = <36 4>, <50 2>;
Would you have an idea what these GPIOs are used for?
Konrad
| |