lkml.org 
[lkml]   [2024]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 6.6 11/52] printk: For @suppress_panic_printk check for other CPU in panic
    Date
    From: John Ogness <john.ogness@linutronix.de>

    [ Upstream commit 0ab7cdd00491b532591ef065be706301de7e448f ]

    Currently @suppress_panic_printk is checked along with
    non-matching @panic_cpu and current CPU. This works
    because @suppress_panic_printk is only set when
    panic_in_progress() is true.

    Rather than relying on the @suppress_panic_printk semantics,
    use the concise helper function other_cpu_in_progress(). The
    helper function exists to avoid open coding such tests.

    Signed-off-by: John Ogness <john.ogness@linutronix.de>
    Reviewed-by: Petr Mladek <pmladek@suse.com>
    Link: https://lore.kernel.org/r/20240207134103.1357162-7-john.ogness@linutronix.de
    Signed-off-by: Petr Mladek <pmladek@suse.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/printk/printk.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
    index 0b3af1529778c..9ca10507f7c47 100644
    --- a/kernel/printk/printk.c
    +++ b/kernel/printk/printk.c
    @@ -2274,8 +2274,7 @@ asmlinkage int vprintk_emit(int facility, int level,
    if (unlikely(suppress_printk))
    return 0;

    - if (unlikely(suppress_panic_printk) &&
    - atomic_read(&panic_cpu) != raw_smp_processor_id())
    + if (unlikely(suppress_panic_printk) && other_cpu_in_panic())
    return 0;

    if (level == LOGLEVEL_SCHED) {
    --
    2.43.0

    \
     
     \ /
      Last update: 2024-05-27 16:15    [W:7.192 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site