Messages in this thread Patch in this message | | | From | Uwe Kleine-König <> | Subject | [PATCH] pwm: Fix setting period with #pwm-cells = <1> and of_pwm_single_xlate() | Date | Fri, 29 Mar 2024 11:35:40 +0100 |
| |
For drivers making use of of_pwm_single_xlate() (i.e. those that don't pass a hwpwm index) and also don't pass flags, setting period was wrongly skipped. This affects the pwm-pxa and ti-sn65dsi86 drivers.
Reported-by: Karel Balej <balejk@matfyz.cz> Fixes: 40ade0c2e794 ("pwm: Let the of_xlate callbacks accept references without period") Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/pwm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 54a62879fffa..ee3ef3f44bc5 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -512,7 +512,7 @@ of_pwm_single_xlate(struct pwm_chip *chip, const struct of_phandle_args *args) if (IS_ERR(pwm)) return pwm; - if (args->args_count > 1) + if (args->args_count > 0) pwm->args.period = args->args[0]; pwm->args.polarity = PWM_POLARITY_NORMAL; -- 2.43.0
| |