lkml.org 
[lkml]   [2024]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: Re: [net-next PATCH v3] octeontx2-pf: Reset MAC stats during probe
Date

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Tuesday, March 12, 2024 3:44 AM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri
> Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
> <gakula@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
Subbaraya
> Sundeep Bhatta <sbhatta@marvell.com>
> Subject: Re: [net-next PATCH v3] octeontx2-pf: Reset MAC
> stats during probe
>
> On Fri, 8 Mar 2024 23:45:44 +0530 Sai Krishna wrote:
> > @@ -3048,6 +3065,9 @@ static int otx2_probe(struct pci_dev *pdev,
> > const struct pci_device_id *id)
> >
> > otx2_qos_init(pf, qos_txqs);
> >
> > + /* reset CGX/RPM MAC stats */
> > + otx2_reset_mac_stats(pf);
> > +
> > return 0;

> Looks suspicious, all sort of resets should be usually done before the
> netdev / devlink instances are registered. As soon as you register
> those they may get brought up and used (including synchronously by an in-
kernel user).

Agreed to your point, will send V4 patch with the suggested change. Apologies for delayed acknowledgement, as I overlooked the review mail.

> --
> pw-bot: cr


\
 
 \ /
  Last update: 2024-05-27 16:14    [W:0.071 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site