Messages in this thread | | | Date | Fri, 29 Mar 2024 10:22:00 -0700 | Subject | Re: [PATCH 1/6] wifi: ath10k: sdio: simplify module initialization | From | Jeff Johnson <> |
| |
On 3/29/2024 10:10 AM, Krzysztof Kozlowski wrote: > This driver's initialization functions do not perform any custom code, > except printing messages. Printing messages on modules > loading/unloading is discouraged because it pollutes the dmesg > regardless whether user actually has this device. Core kernel code > already gives tools to investigate whether module was loaded or not. > > Drop the printing messages which allows to replace open-coded > module_sdio_driver(). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> > --- > > FYI: > I have ongoing patchset touching few lines above this patch chunk > (sdio_driver) which might go via different tree. If that patchset is > applied via different tree, it might result in a trivial conflict, but > there is no dependency. They can go via separate trees (except that > trivial conflict).
I'll let Kalle respond if he'll take this through the ath tree vs letting you take it through your tree
| |