lkml.org 
[lkml]   [2024]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v6 17/17] net: pse-pd: Add TI TPS23881 PSE controller driver
    On Thu, 28 Mar 2024 17:24:17 +0100
    Andrew Lunn <andrew@lunn.ch> wrote:

    > > +static int tps23881_flash_fw_part(struct i2c_client *client,
    > > + const char *fw_name,
    > > + const struct tps23881_fw_conf *fw_conf)
    >
    > Does the device actually have flash? Or is this just downloading to
    > SRAM?

    It is downloading to SRAM.

    >
    > > +{
    > > + const struct firmware *fw = NULL;
    > > + int i, ret;
    > > +
    > > + ret = request_firmware(&fw, fw_name, &client->dev);
    > > + if (ret)
    > > + return ret;
    > > +
    > > + dev_info(&client->dev, "Flashing %s\n", fw_name);
    >
    > If this is a one-time thing whenever there is a new firmware version
    > dropped into /lib/firmware, this would be O.K. However, if this
    > happens every boot, i would use dev_dbg().

    Ok I will change to dev_dbg then.
    Thanks!

    Regards,
    --
    Köry Maincent, Bootlin
    Embedded Linux and kernel engineering
    https://bootlin.com

    \
     
     \ /
      Last update: 2024-05-27 16:15    [W:4.194 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site