Messages in this thread | | | Date | Wed, 27 Mar 2024 09:55:55 +0000 | Subject | Re: [PATCH v2 03/20] media: venus: pm_helpers: Add kerneldoc to venus_clks_get() | From | Bryan O'Donoghue <> |
| |
On 26/03/2024 21:23, Konrad Dybcio wrote: > On 6.03.2024 1:20 PM, Bryan O'Donoghue wrote: >> On 09/02/2024 21:09, Konrad Dybcio wrote: >>> To make it easier to understand the various clock requirements within >>> this driver, add kerneldoc to venus_clk_get() explaining the fluff. >>> >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>> --- >>> drivers/media/platform/qcom/venus/pm_helpers.c | 28 ++++++++++++++++++++++++++ >>> 1 file changed, 28 insertions(+) >>> >>> diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c >>> index ac7c83404c6e..ea0a7d4601e2 100644 >>> --- a/drivers/media/platform/qcom/venus/pm_helpers.c >>> +++ b/drivers/media/platform/qcom/venus/pm_helpers.c >>> @@ -23,6 +23,34 @@ >>> static bool legacy_binding; >>> +/** >>> + * venus_clks_get() - Get Venus clocks that are not bound to a vcodec >> >> Get non-codec Venus clocks. > > No, this is not necessarily the case.. these may still include > vcodec clocks, that are specified under the root venus node (which > is the only way we'd like to keep) > > I applied the rest of your suggestions, do I keep your rb? > > Konrad >
Sure
BTW, I plan to test this series when I can - do you have a working tree ?
--- bod
| |