Messages in this thread | ![/](/images/icornerl.gif) | | From | Kate Hsuan <> | Date | Wed, 27 Mar 2024 14:32:59 +0800 | Subject | Re: [PATCH v5 RESEND 5/6] power: supply: power-supply-leds: Add charging_red_full_green trigger for RGB LED |
| |
Hi Andy,
On Mon, Mar 25, 2024 at 4:11 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Sun, Mar 24, 2024 at 5:02 PM Kate Hsuan <hpa@redhat.com> wrote: > > > > Add a charging_red_full_green LED trigger and the trigger is based on > > led_mc_trigger_event() which can set an RGB LED when the trigger is > > triggered. The LED will show red when the battery status is charging. > > The LED will show green when the battery status is full. > > > > Link: https://lore.kernel.org/linux-leds/f40a0b1a-ceac-e269-c2dd-0158c5b4a1ad@gmail.com/T/#t > > You can drop the 'T/#t' part. > > ... > > > + led_mc_trigger_event(psy->charging_red_full_green_trig, > > + intensity_green, > > + 3, > > ARRAY_SIZE() > > > + LED_FULL); > > ... > > > + led_mc_trigger_event(psy->charging_red_full_green_trig, > > + intensity_red, > > + 3, > > Ditto. > > > + LED_FULL); > > ... > > > + led_mc_trigger_event(psy->charging_red_full_green_trig, > > + intensity_red, > > + 3, > > Ditto. > > > + LED_OFF); > > -- > With Best Regards, > Andy Shevchenko >
Thank you for reviewing it. I'll fix it in the v6 patch.
-- BR, Kate
| ![\](/images/icornerr.gif) |