Messages in this thread | | | From | Miguel Ojeda <> | Date | Wed, 27 Mar 2024 19:14:12 +0100 | Subject | Re: [PATCH 1/2] drm/qxl: remove unused `count` variable from `qxl_surface_id_alloc()` |
| |
On Wed, Mar 27, 2024 at 6:56 PM Miguel Ojeda <ojeda@kernel.org> wrote: > > Closes: https://lore.kernel.org/lkml/CANiq72mjc5t4n25SQvYSrOEhxxpXYPZ4pPzneSJHEnc3qApu2Q@mail.gmail.com/
Should have a [1] at the end.
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org> > --- > Given there is a loop going on here, it would be good to double-check whether > this variable was supposed to be used for something useful or if it was just a > remnant of a version previous to v1.4.
Also, I see Nathan sent meanwhile a message about these two that were also mentioned/reported a while ago [1].
On my side, I noticed these due to my loongarch64 defconfig compile-test with Rust enabled yesterday [2], but I don't want to step on Tom/Colin/Nathan/ClangBuiltLinux's work, so please feel free to do with these patches as you will!
Thanks!
Cheers, Miguel
[1] https://lore.kernel.org/all/20240327163331.GB1153323@dev-arch.thelio-3990X/ [2] https://lore.kernel.org/lkml/CANiq72mjc5t4n25SQvYSrOEhxxpXYPZ4pPzneSJHEnc3qApu2Q@mail.gmail.com/
| |