Messages in this thread | | | From | "Trivedi Manojbhai, Naman" <> | Subject | RE: [PATCH] drivers: clk: zynqmp: remove clock name dependency | Date | Wed, 27 Mar 2024 05:47:28 +0000 |
| |
Hi Stephen,
I am awaiting your response for the below query. Can you please help me with the same?
Thanks, Naman
>-----Original Message----- >From: Trivedi Manojbhai, Naman >Sent: Thursday, March 7, 2024 11:37 AM >To: Stephen Boyd <sboyd@kernel.org>; Simek, Michal ><michal.simek@amd.com>; robh@kernel.org >Cc: linux-clk@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- >kernel@vger.kernel.org >Subject: RE: [PATCH] drivers: clk: zynqmp: remove clock name dependency > >Hi Stephen, > >>-----Original Message----- >>From: Stephen Boyd <sboyd@kernel.org> >>Sent: Thursday, January 4, 2024 6:30 AM >>To: Trivedi Manojbhai, Naman <Naman.TrivediManojbhai@amd.com>; >>abel.vesa@linaro.org; angelogioacchino.delregno@collabora.com; >>krzysztof.kozlowski@linaro.org; Simek, Michal <michal.simek@amd.com>; >>mturquette@baylibre.com; robh@kernel.org >>Cc: linux-clk@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >>linux- kernel@vger.kernel.org; Trivedi Manojbhai, Naman >><Naman.TrivediManojbhai@amd.com> >>Subject: Re: [PATCH] drivers: clk: zynqmp: remove clock name dependency >> >>Caution: This message originated from an External Source. Use proper >>caution when opening attachments, clicking links, or responding. >> >> >>Quoting Naman Trivedi Manojbhai (2024-01-02 23:20:17) >>> Currently, from zynqmp_get_parent_list() function the clock driver >>> references the clock by name instead of its reference from device tree. >>> This causes problem when the clock name in the device tree is changed. >>> >>> Remove hard dependency of clock name and update the logic to use >>> clock reference from device tree instead of clock name. >> >>Please use struct clk_parent_data instead. >Thanks for review. As per my understanding, you suggest to replace the >proposed logic, and use "struct clk_parent_data" to get the clock name from >device tree. > >I have gone through other drivers which use the "struct clk_parent_data" >structure, they have hard coded clock names in the driver. In zynqmp, the >driver receives clock name from firmware. > >Also, the "zynqmp_get_parent_list" function is called before clocks are >registered. So at this point, we don't have the hw structure which has >clk_parent_data. > >So, I did not get how to use the struct clk_parent_data in this case. Can you >please provide an example which I can look at as a reference? > >Thanks, >Naman
| |