Messages in this thread | | | From | Ratheesh Kannoth <> | Subject | RE: [EXTERNAL] Re: [PATCH net-next v2] tg3: Remove residual error handling in tg3_suspend | Date | Wed, 27 Mar 2024 05:13:03 +0000 |
| |
> From: Michael Chan <michael.chan@broadcom.com> > Sent: Wednesday, March 27, 2024 10:39 AM > To: Jakub Kicinski <kuba@kernel.org> > Cc: Ratheesh Kannoth <rkannoth@marvell.com>; Nikita Kiryushin > <kiryushin@ancud.ru>; Michael Chan <mchan@broadcom.com>; Pavan > Chebbi <pavan.chebbi@broadcom.com>; David S. Miller > <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Paolo > Abeni <pabeni@redhat.com>; Rafael J. Wysocki <rjw@rjwysocki.net>; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; lvc- > project@linuxtesting.org > Subject: [EXTERNAL] Re: [PATCH net-next v2] tg3: Remove residual error > handling in tg3_suspend > > Prioritize security for external emails: Confirm sender and content safety > before clicking links or opening attachments > > ---------------------------------------------------------------------- > On Tue, Mar 26, 2024 at 8:24 PM Jakub Kicinski <kuba@kernel.org> wrote: > > > > On Wed, 27 Mar 2024 08:14:30 +0530 Ratheesh Kannoth wrote: > > > > @@ -18090,7 +18090,6 @@ static int tg3_suspend(struct device > *device) > > > > { > > > Please address Michael Chan's comment to make this function return type > to "void" > > > instead of "int" > > > > It's used as a callback in SIMPLE_DEV_PM_OPS(), how would that work? > > It won't work. I only requested to change tg3_power_down_prepare() to > void and it was done in v2: > > https://lore.kernel.org/netdev/CACKFLinzJjqe0j4OFkcCV+FyH0JiUpnj3j2azZk > GaC9jfvFXrQ@mail.gmail.com/ Got it. Thanks.
| |