Messages in this thread | | | Date | Wed, 27 Mar 2024 12:51:32 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v2] rcu-tasks: Update show_rcu_tasks_trace_gp_kthread buffer size |
| |
On Wed, 27 Mar 2024 19:36:56 +0300 Nikita Kiryushin <kiryushin@ancud.ru> wrote:
> diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h > index 147b5945d67a..963ecae3c8e6 100644 > --- a/kernel/rcu/tasks.h > +++ b/kernel/rcu/tasks.h > @@ -1994,7 +1994,7 @@ void show_rcu_tasks_trace_gp_kthread(void) > { > char buf[64]; > > - sprintf(buf, "N%lu h:%lu/%lu/%lu", > + snprintf(buf, ARRAY_SIZE(buf), "N%lu h:%lu/%lu/%lu",
Nit, but I would have used sizeof(buf) instead of ARRAY_SIZE(buf) as that's more common practice for this type of code.
[ do a: git grep 'sizeof(buf)' ]
-- Steve
> data_race(n_trc_holdouts), > data_race(n_heavy_reader_ofl_updates), > data_race(n_heavy_reader_updates),
| |