lkml.org 
[lkml]   [2024]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 1/3] dt-bindings: mtd: Add Loongson-1 NAND Controller
    On Wed, Mar 27, 2024 at 06:43:59PM +0800, Keguang Zhang via B4 Relay wrote:
    > From: Keguang Zhang <keguang.zhang@gmail.com>
    >
    > Add devicetree binding document for Loongson-1 NAND Controller.
    >
    > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
    > ---
    > Changes in v6:
    > - A newly added patch
    > ---
    > .../devicetree/bindings/mtd/loongson,ls1x-nfc.yaml | 66 ++++++++++++++++++++++
    > 1 file changed, 66 insertions(+)
    >
    > diff --git a/Documentation/devicetree/bindings/mtd/loongson,ls1x-nfc.yaml b/Documentation/devicetree/bindings/mtd/loongson,ls1x-nfc.yaml
    > new file mode 100644
    > index 000000000000..2494c7b3b506
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/mtd/loongson,ls1x-nfc.yaml
    > @@ -0,0 +1,66 @@
    > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/mtd/loongson,ls1x-nfc.yaml#

    Please make the filename match the compatible.

    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: Loongson-1 NAND Controller
    > +
    > +maintainers:
    > + - Keguang Zhang <keguang.zhang@gmail.com>
    > +
    > +allOf:
    > + - $ref: nand-controller.yaml
    > +
    > +properties:
    > + compatible:
    > + oneOf:
    > + - const: loongson,ls1b-nfc
    > + - items:
    > + - enum:
    > + - loongson,ls1a-nfc
    > + - loongson,ls1c-nfc
    > + - const: loongson,ls1b-nfc
    > +
    > + reg:
    > + maxItems: 1
    > +
    > + dmas:
    > + maxItems: 1
    > +
    > + dma-names:
    > + const: rxtx

    If you only have one dma, why do you need a dma-names entry for it?

    Looks fine to me otherwise though,
    COnor.

    > +
    > +patternProperties:
    > + "^nand@[0-3]$":
    > + type: object
    > + $ref: raw-nand-chip.yaml
    > +
    > + unevaluatedProperties: false
    > +
    > +required:
    > + - compatible
    > + - reg
    > + - dmas
    > + - dma-names
    > +
    > +unevaluatedProperties: false
    > +
    > +examples:
    > + - |
    > + nand-controller@1fe78000 {
    > + compatible = "loongson,ls1b-nfc";
    > + reg = <0x1fe78000 0x40>;
    > +
    > + #address-cells = <1>;
    > + #size-cells = <0>;
    > +
    > + dmas = <&dma 0>;
    > + dma-names = "rxtx";
    > +
    > + nand@0 {
    > + reg = <0>;
    > + nand-use-soft-ecc-engine;
    > + nand-ecc-algo = "hamming";
    > + };
    > + };
    >
    > --
    > 2.40.1
    >
    >
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2024-05-27 16:12    [W:8.563 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site