lkml.org 
[lkml]   [2024]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 0/7] riscv: Various text patching improvements
    From
    Hi Andrea,

    On 2024-02-13 6:58 AM, Andrea Parri wrote:
    > On Sun, Feb 11, 2024 at 06:55:11PM -0800, Samuel Holland wrote:
    >> Here are a few changes to minimize calls to stop_machine() and
    >> flush_icache_*() in the various text patching functions, as well as
    >> to simplify the code.
    >>
    >>
    >> Samuel Holland (7):
    >> riscv: jump_label: Batch icache maintenance
    >> riscv: jump_label: Simplify assembly syntax
    >> riscv: kprobes: Use patch_text_nosync() for insn slots
    >> riscv: Simplify text patching loops
    >> riscv: Pass patch_text() the length in bytes
    >> riscv: Use offset_in_page() in text patching functions
    >> riscv: Remove extra variable in patch_text_nosync()
    >
    > This does look like a nice clean-up. Just curious (a "teach me"-like question),
    > how did you test these changes? kselftests, micro-benchmarks, other?

    For all my patches, I do boot testing on various physical boards (Unmatched, D1,
    some internal hardware), plus some standard internal workloads. For
    performance-related patches, I run microbenchmarks or whole-system benchmarks
    (e.g. UnixBench). For this series specifically, I didn't do any extra
    benchmarking, as all of the functional changes should be as fast or faster by
    virtue of simply doing less work.

    > BTW, I recall a parallel work from Alex and Bjorn [1] that might have some minor
    > conflict with these changes; + both of them to Cc: for further sync.

    As suggested by Alex, v2 of this series will be based on the latest version of
    that patch.

    Regards,
    Samuel

    >
    > Andrea
    >
    > [1] https://lore.kernel.org/lkml/20240206204607.527195-1-alexghiti@rivosinc.com/


    \
     
     \ /
      Last update: 2024-05-27 16:12    [W:6.768 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site