Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sat, 23 Mar 2024 23:25:42 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH 1/3] leds: trigger: legtrig-bpf: Add ledtrig-bpf module |
| |
> A new kernel module just to call this helper? > Feels like overkill. Can it be a part of generic led bits? > btw, have you looked at net/netfilter/xt_LED.c ? > netfilter had the ability to blink led for a long time. > I'm curious whether folks found it useful.
This might become more useful now that we have support for PHY & MAC LEDs. You can use the netdev trigger for the usual things an RJ45 LED shows: link, rx/tx activity, link speed etc. But they are just Linux LEDs, you can also use them for heartbeat, disc IO, tty IO, or xt_LED. xt_LED would actually make sense for an LED in a RJ45 socket.
Andrew
| ![\](/images/icornerr.gif) |