Messages in this thread |  | | Date | Sat, 23 Mar 2024 12:15:47 +0100 | | Subject | Re: [PATCH v2 1/5] dt-bindings: mfd: Add rk816 binding | | From | Alex Bee <> |
| |
Am 23.03.24 um 12:02 schrieb Krzysztof Kozlowski: > On 23/03/2024 11:56, Alex Bee wrote: >> Hi Krzysztof, >> >> Am 23.03.24 um 11:32 schrieb Krzysztof Kozlowski: >>> On 23/03/2024 09:58, Alex Bee wrote: >>>> Add DT binding document for Rockchip's RK816 PMIC >>>> >>>> Signed-off-by: Alex Bee <knaerzche@gmail.com> >>>> --- >>>> changes since v1: >>>> - lowercase/hyphens for regulator node names >>>> - rename "-reg" to "-regulator" to make node names generic >>> I don't understand why did you do it. I did not ask for it. If you want >>> to rename, drop redundant regulator or reg suffix from node names. >> You didn't ask for that, thats true. >> >> I did it regardless, since node names should be generic and the "-reg" > device node names, here you do not have devices. OK. I wasn't aware there's a difference between device nodes and devices. I'll drop the suffix from the regulators. > You did not respond to rest of my comments, so I assume you agree 100% > with them.
I do.
Alex.
>
|  |