On Thu, Mar 21, 2024 at 02:55:27PM +0530, Jagadeesh Kona wrote:
> Add device tree bindings for the camera clock controller on
> Qualcomm SM8650 platform.
> 
> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Did Krzysztof really review this version?

> @@ -18,6 +19,7 @@ description: |
>      include/dt-bindings/clock/qcom,sm8550-camcc.h
>      include/dt-bindings/clock/qcom,sc8280xp-camcc.h
>      include/dt-bindings/clock/qcom,x1e80100-camcc.h
> +    include/dt-bindings/clock/qcom,sm8650-camcc.h

This does not look like alphabetical order.

>  allOf:
>    - $ref: qcom,gcc.yaml#
> @@ -29,6 +31,7 @@ properties:
>        - qcom,sm8450-camcc
>        - qcom,sm8550-camcc
>        - qcom,x1e80100-camcc
> +      - qcom,sm8650-camcc

And neither does this.

Johan