Messages in this thread | | | Date | Wed, 20 Mar 2024 10:59:22 -0700 | Subject | Re: [PATCH v4] hv/hv_kvp_daemon: Handle IPv4 and Ipv6 combination for keyfile format | From | Easwar Hariharan <> |
| |
On 3/20/2024 4:17 AM, Shradha Gupta wrote: > If the network configuration strings are passed as a combination of IPv4 > and IPv6 addresses, the current KVP daemon does not handle processing for > the keyfile configuration format. > With these changes, the keyfile config generation logic scans through the > list twice to generate IPv4 and IPv6 sections for the configuration files > to handle this support. > > Testcases ran:Rhel 9, Hyper-V VMs > (IPv4 only, IPv6 only, IPv4 and IPv6 combination) > Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com> > --- > Changes in v4 > * Removed the unnecessary memset for addr in the start > * Added a comment to describe how we erase the last comma character > * Fixed some typos in the commit description > * While using strncat, skip copying the '\0' character. > --- > tools/hv/hv_kvp_daemon.c | 181 ++++++++++++++++++++++++++++++--------- > 1 file changed, 140 insertions(+), 41 deletions(-) >
<snip> LGTM
Reviewed-by: Easwar Hariharan <eahariha@linux.microsoft.com>
- Easwar
| |