Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 20 Mar 2024 17:14:33 +0100 | From | David Sterba <> | Subject | Re: [PATCH] btrfs: allocate btrfs_ioctl_defrag_range_args on stack |
| |
On Wed, Mar 20, 2024 at 11:31:56AM +0000, Maximilian Heyne wrote: > From: Goldwyn Rodrigues <rgoldwyn@suse.com> > > commit c853a5783ebe123847886d432354931874367292 upstream. > > Instead of using kmalloc() to allocate btrfs_ioctl_defrag_range_args, > allocate btrfs_ioctl_defrag_range_args on stack, the size is reasonably > small and ioctls are called in process context. > > sizeof(btrfs_ioctl_defrag_range_args) = 48 > > Reviewed-by: Anand Jain <anand.jain@oracle.com> > Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com> > Reviewed-by: David Sterba <dsterba@suse.com> > Signed-off-by: David Sterba <dsterba@suse.com> > CC: stable@vger.kernel.org # 4.14+ > [ This patch is needed to fix a memory leak of "range" that was > introduced when commit 173431b274a9 ("btrfs: defrag: reject unknown > flags of btrfs_ioctl_defrag_range_args") was backported to kernels > lacking this patch. Now with these two patches applied in reverse order, > range->flags needed to change back to range.flags. > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc.] > Signed-off-by: Maximilian Heyne <mheyne@amazon.de>
Acked-by: David Sterba <dsterba@suse.com>
for backport to stable as a prerequisite for 173431b274a9a5 ("btrfs: defrag: reject unknown flags of btrfs_ioctl_defrag_range_args").
| ![\](/images/icornerr.gif) |