Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 20 Mar 2024 15:21:00 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v2 2/2] ASoC: cdns: Add drivers of Cadence Multi-Channel I2S Controller |
| |
On Wed, Mar 20, 2024 at 10:00:24AM -0500, Pierre-Louis Bossart wrote:
> > + for (i = 0; i < CDNS_I2S_FIFO_DEPTH; i++) { > > + if (format == SNDRV_PCM_FORMAT_S16_LE) { > > + data[0] = p16[tx_ptr][0]; > > + data[1] = p16[tx_ptr][1]; > > + } else if (format == SNDRV_PCM_FORMAT_S32_LE) { > > + data[0] = p32[tx_ptr][0]; > > + data[1] = p32[tx_ptr][1]; > > + }
> what about other formats implied by the use of 'else if' ?
In general things like this should be written as switch statements. [unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |