Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Claus Hansen Ries <> | Subject | [PATCH net v2] net: ll_temac: platform_get_resource replaced by wrong function | Date | Wed, 20 Mar 2024 14:19:15 +0000 |
| |
From: Claus Hansen Ries <chr@terma.com>
Hope I am resubmitting this correctly, I've fixed the issues in the original submission.
platform_get_resource was replaced with devm_platform_ioremap_resource_byname and is called using 0 as name. This eventually ends up in platform_get_resource_byname in the call stack, where it causes a null pointer in strcmp.
if (type == resource_type(r) && !strcmp(r->name, name))
It should have been replaced with devm_platform_ioremap_resource.
Fixes: bd69058f50d5 ("net: ll_temac: Use devm_platform_ioremap_resource_byname()") Signed-off-by: Claus Hansen Ries <chr@terma.com> Cc: stable@vger.kernel.org --- v2: - fix accidently converting tabs to spaces and wording in commit message v1: https://marc.info/?l=linux-netdev&m=171087828129633&w=2
drivers/net/ethernet/xilinx/ll_temac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index 9df39cf8b097..1072e2210aed 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -1443,7 +1443,7 @@ static int temac_probe(struct platform_device *pdev) } /* map device registers */ - lp->regs = devm_platform_ioremap_resource_byname(pdev, 0); + lp->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(lp->regs)) { dev_err(&pdev->dev, "could not map TEMAC registers\n"); return -ENOMEM; base-commit: d95fcdf4961d27a3d17e5c7728367197adc89b8d -- 2.39.3 (Apple Git-146)
| ![\](/images/icornerr.gif) |