lkml.org 
[lkml]   [2024]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 1/2] dt-bindings: hwmon: pmbus: adp1050: add bindings
From
On 20/03/2024 14:05, Sabau, Radu bogdan wrote:

>> +examples:
>> + - |
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clock-frequency = <100000>;
>> +
>> + hwmon@70 {
>> + compatible = "adi,adp1050";
>> + reg = <0x70>;
>> + vcc-supply = <&vcc>;
>> + };
>> + };
>> +...
>
> Results of bindings testing :
>

Yeah... please do not send patches which contain knowingly wrong code.
Code is wrong if you perform testing and result is some sort of FAILURE,
build error, warning message, static checker/linter warning message or
error.

If something is not clear, ask via email or IRC, but sending code which
does not work could cause wasted reviewer's effort.

About your warning, please start your bindings from example-schema or
latest reviewed bindings.

Best regards,
Krzysztof


\
 
 \ /
  Last update: 2024-05-27 15:56    [W:0.200 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site