Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH] rust: time: add Ktime | Date | Wed, 20 Mar 2024 14:18:51 +0100 |
| |
On Wed, Mar 20 2024 at 10:08, Alice Ryhl wrote: > +impl Ktime { > + /// Create a `Ktime` from a raw `ktime_t`. > + #[inline] > + pub fn from_raw(inner: bindings::ktime_t) -> Self { > + Self { inner } > + } > + > + /// Get the current time using `CLOCK_MONOTONIC`. > + #[inline] > + pub fn ktime_get() -> Self { > + // SAFETY: It is always safe to call `ktime_get`.
That's not entirely correct. ktime_get() cannot be safely invoked from NMI context. That won't matter for driver writers obviously.
Looks sensible otherwise.
Thanks,
tglx
| |