lkml.org 
[lkml]   [2024]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] dt-bindings: iio: adc: nxp,imx93-adc.yaml: Add calibration properties
From
Hi Krzysztof,

On 20. 03. 24 11:26, Krzysztof Kozlowski wrote:
> On 20/03/2024 11:04, Andrej Picej wrote:
>> Document calibration properties and how to set them.
>
> Bindings are before users.

will change patch order when I send a v2.

>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.
> There is no file extension in prefixes.

So: dt-bindings: iio/adc: nxp,imx93-adc: Add calibration properties?

>
>>
>> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
>> ---
>> .../bindings/iio/adc/nxp,imx93-adc.yaml | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
>> index dacc526dc695..64958be62a6a 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
>> +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
>> @@ -46,6 +46,21 @@ properties:
>> "#io-channel-cells":
>> const: 1
>>
>> + nxp,calib-avg-en:
>> + description:
>> + Enable or disable averaging of calibration time.
>> + enum: [ 0, 1 ]
>> +
>> + nxp,calib-nr-samples:
>> + description:
>> + Selects the number of averaging samples to be used during calibration.
>> + enum: [ 16, 32, 128, 512 ]
>> +
>> + nxp,calib-t-samples:
>> + description:
>> + Specifies the sample time of calibration conversions.
>> + enum: [ 8, 16, 22, 32 ]
>
> No, use existing, generic properties. Open other bindings for this.

You mean I should use generic properties for the ADC calibration
settings? Is there already something in place? Because as I understand
it, these calib-* values only effect the calibration process of the ADC.

>
> Also, none of these were tested. I am not going to review such untested
> code.
>
> It does not look like you tested the bindings, at least after quick
> look. Please run `make dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
> Maybe you need to update your dtschema and yamllint.

You are right, I did not run the dt_binding_check, sorry for this,
forgot that this existed. I see now I have to add the:
> $ref: /schemas/types.yaml#/definitions/uint32

Will fix in v2.

BR,
Andrej

>
> Best regards,
> Krzysztof
>

\
 
 \ /
  Last update: 2024-05-27 15:55    [W:0.126 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site