Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 20 Mar 2024 11:12:10 +0100 | Subject | Re: [PATCH v2] pinctrl: renesas: rzg2l: Execute atomically the interrupt configuration |
| |
On Mon, Mar 18, 2024 at 3:31 PM Claudiu <claudiu.beznea@tuxon.dev> wrote: > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > Lockdep detects a possible deadlock as listed below. This is because it > detects the IA55 interrupt controller .irq_eoi() API is called from > interrupt context while configuration-specific API (e.g., .irq_enable()) > could be called from process context on resume path (by calling > rzg2l_gpio_irq_restore()). To avoid this, protect the call of > rzg2l_gpio_irq_enable() with spin_lock_irqsave()/spin_unlock_irqrestore(). > With this the same approach that is available in __setup_irq() is mimicked > to pinctrl IRQ resume function. > > Below is the lockdep report:
[...]
> Fixes: 254203f9a94c ("pinctrl: renesas: rzg2l: Add suspend/resume support") > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > --- > > Changes in v2: > - used raw_spin_lock_irqsave()/raw_spin_unlock_irqrestore()
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-pinctrl for v6.10.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |