Messages in this thread | | | Date | Wed, 20 Mar 2024 10:47:05 +0100 | Subject | Re: [PATCH v2 3/5] dt-bindings: serial: amlogic,meson-uart: Add compatible string for A4 | From | Krzysztof Kozlowski <> |
| |
On 20/03/2024 10:44, Xianwei Zhao via B4 Relay wrote: > From: Xianwei Zhao <xianwei.zhao@amlogic.com> > > Amlogic A4 SoCs uses the same UART controller as S4 SoCs and G12A. > There is no need for an extra compatible line in the driver, but > add A4 compatible line for documentation. > > Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com> > --- > Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml > index 2e189e548327..d05c45815dc2 100644 > --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml > +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml > @@ -54,7 +54,9 @@ properties: > - const: amlogic,meson-gx-uart > - description: UART controller on S4 compatible SoCs > items: > - - const: amlogic,t7-uart > + - enum: > + - amlogic,t7-uart > + - amlogic,a4-uart
Keep alphabetical order. Don't add stuff to the end of lists. This comment applies in general, for almost all your patches, so also future submissions.
Best regards, Krzysztof
| |