Messages in this thread | | | Date | Wed, 20 Mar 2024 00:16:02 +0300 | Subject | Re: [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch | From | Arınç ÜNAL <> |
| |
On 19.03.2024 23:26, Daniel Golle wrote: > On Tue, Mar 19, 2024 at 08:38:03PM +0100, Andrew Lunn wrote: >>> I would argue that EEE advertisement on the PHY should be enabled by >>> default. >> >> That is an open question at the moment. For some use cases, it can add >> extra delay and jitter which can cause problems. I've heard people >> doing PTP don't like EEE for example. > > MediaTek consumer-grade hardware doesn't support PTP and hence that > quite certainly won't ever be an issue with all switch ICs supported > by the mt7530 driver. > > I'd rather first change the (configuration) default in OpenWrt (which > is arguable the way most people are using this hardware), also because > that will be more visible/obvious for users. Or even just make EEE > configurable in the LuCI web-UI as a first step so users start playing > with it. > > After all, I also have a hard time imagining that MediaTek disabled > EEE in their downstream driver for no reason: > > https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/24091177a18ba7f2dd8d928a8f5b27b14df46b16
Are you saying this to indicate that we shouldn't remove that from mediatek-ge? If so, I've already explained that there'd be no practical change in removing it as both MT7530 and MT7531 switches enable EEE advertisement after mediatek-ge.
Arınç
| |