lkml.org 
[lkml]   [2024]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 2/8] drm: zynqmp_dp: Downgrade log level for aux retries message
    From
    On 20/03/2024 00:51, Sean Anderson wrote:
    > Enable this message for verbose debugging only as it is otherwise
    > printed after every AUX message, quickly filling the log buffer.
    >
    > Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
    > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    > ---
    >
    > (no changes since v1)
    >
    > drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
    > index a0606fab0e22..98a32e6a0459 100644
    > --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
    > +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
    > @@ -1006,7 +1006,7 @@ zynqmp_dp_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)
    > msg->buffer, msg->size,
    > &msg->reply);
    > if (!ret) {
    > - dev_dbg(dp->dev, "aux %d retries\n", i);
    > + dev_vdbg(dp->dev, "aux %d retries\n", i);
    > return msg->size;
    > }
    >

    Yes, these are annoying... In my work branch I had added "if (i)" there,
    so that this is only printed if there actually are retries.

    But this is fine too (or even dropping the print totally), so:

    Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

    Tomi


    \
     
     \ /
      Last update: 2024-05-27 15:55    [W:6.563 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site