Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 20 Mar 2024 07:42:23 +0200 | Subject | Re: [PATCH v2 1/8] drm: xlnx: Fix kerneldoc | From | Tomi Valkeinen <> |
| |
On 20/03/2024 00:51, Sean Anderson wrote: > Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed > members. > > Signed-off-by: Sean Anderson <sean.anderson@linux.dev> > --- > > Changes in v2: > - New > > drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++--- > drivers/gpu/drm/xlnx/zynqmp_dpsub.h | 1 + > drivers/gpu/drm/xlnx/zynqmp_kms.h | 4 ++-- > 3 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c > index 407bc07cec69..f79bf3fb8110 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c > @@ -128,9 +128,9 @@ struct zynqmp_disp_layer { > * struct zynqmp_disp - Display controller > * @dev: Device structure > * @dpsub: Display subsystem > - * @blend.base: Register I/O base address for the blender > - * @avbuf.base: Register I/O base address for the audio/video buffer manager > - * @audio.base: Registers I/O base address for the audio mixer > + * @blend: Register I/O base address for the blender > + * @avbuf: Register I/O base address for the audio/video buffer manager > + * @audio: Registers I/O base address for the audio mixer
Afaics, the kernel doc guide:
https://docs.kernel.org/doc-guide/kernel-doc.html#nested-structs-unions
says that the current version is correct. Or is the issue that while, say, 'base' is documented, 'blend' was not?
Tomi
| ![\](/images/icornerr.gif) |