Messages in this thread | | | Subject | Re: [PATCH] ARM: unwind: improve unwinders for noreturn case | From | Jiangfeng Xiao <> | Date | Wed, 20 Mar 2024 11:46:31 +0800 |
| |
On 2024/3/20 11:34, Matthew Wilcox wrote: > On Wed, Mar 20, 2024 at 11:30:13AM +0800, Jiangfeng Xiao wrote: >> The checkpatch.pl script reports the "WARNING: printk() should >> include KERN_<LEVEL> facility level" warning. >> >> That's why I changed printk to pr_warn. >> I should change printk to printk(KERN_DEFAULT). > > No, you should ignore checkpatch. For bonus points, figure out why you > should ignore it specifically in this case. > . >
Thank you. I think I understand.
The checkpatch.pl file is a false report because the 'loglvl' already exists.
I'd better keep printk(" %s...", loglvl, ...) still.
| |