lkml.org 
[lkml]   [2024]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 4/5] perf trace: Beautify the 'flags' arg of unlinkat
On Wed, Mar 20, 2024 at 12:31 PM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Reusing the fs_at_flags array done for the 'stat' syscall.
>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Ian Rogers <irogers@google.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
> tools/perf/builtin-trace.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index 58546e8af9fcf481..ef0dfffd99fdf3cc 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -1171,7 +1171,9 @@ static const struct syscall_fmt syscall_fmts[] = {
> .arg = { [0] = { .scnprintf = SCA_FILENAME, /* name */ }, }, },
> { .name = "uname", .alias = "newuname", },
> { .name = "unlinkat",
> - .arg = { [0] = { .scnprintf = SCA_FDAT, /* dfd */ }, }, },
> + .arg = { [0] = { .scnprintf = SCA_FDAT, /* dfd */ },
> + [1] = { .scnprintf = SCA_FILENAME, /* pathname */ },
> + [2] = { .scnprintf = SCA_FS_AT_FLAGS, /* flags */ }, }, },
> { .name = "utimensat",
> .arg = { [0] = { .scnprintf = SCA_FDAT, /* dirfd */ }, }, },
> { .name = "wait4", .errpid = true,
> --
> 2.44.0
>

\
 
 \ /
  Last update: 2024-05-27 15:57    [W:0.100 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site