Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 20 Mar 2024 23:40:56 +0300 | Subject | Re: [PATCH 3/3] net: phy: mediatek-ge: do not disable EEE advertisement | From | Arınç ÜNAL <> |
| |
On 18.03.2024 10:46, Arınç ÜNAL via B4 Relay wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > There's no need to disable Energy-Efficient Ethernet (EEE) advertisement on > the MT7530 and MT7531 switch PHYs. EEE works fine on MT7530 and MT7531 > switch PHYs. Remove the code where EEE advertisement is disabled. > > This is a bugfix because there's a possible race condition where the > mediatek-ge driver would kick in after the MT7530 DSA subdriver which would > have EEE disabled until manually enabled.
Can I get an opinion on this? Is it actually possible that the PHY driver would start probing after the DSA subdriver? On the console logs for the DSA subdriver, I can see that the name of the PHY driver will appear, which makes me believe the PHY driver would actually never probe after the DSA subdriver.
[ 4.402641] mt7530-mdio mdio-bus:1f wan (uninitialized): PHY [mt7530-0:00] driver [MediaTek MT7530 PHY] (irq=POLL) [ 4.420392] mt7530-mdio mdio-bus:1f lan0 (uninitialized): PHY [mt7530-0:01] driver [MediaTek MT7530 PHY] (irq=POLL) [ 4.437791] mt7530-mdio mdio-bus:1f lan1 (uninitialized): PHY [mt7530-0:02] driver [MediaTek MT7530 PHY] (irq=POLL) [ 4.455096] mt7530-mdio mdio-bus:1f lan2 (uninitialized): PHY [mt7530-0:03] driver [MediaTek MT7530 PHY] (irq=POLL) [ 4.472422] mt7530-mdio mdio-bus:1f lan3 (uninitialized): PHY [mt7530-0:04] driver [MediaTek MT7530 PHY] (irq=POLL)
I don't want to submit a bugfix to the net tree if the bug won't ever happen in real life.
Arınç
| ![\](/images/icornerr.gif) |